Skip to content

fix(ddtrace/tracer): postpone span events/links serialization (#3429)#3435

Merged
darccio merged 1 commit into
release-v1.73.xfrom
v1-fix-incident-37240
Apr 15, 2025
Merged

fix(ddtrace/tracer): postpone span events/links serialization (#3429)#3435
darccio merged 1 commit into
release-v1.73.xfrom
v1-fix-incident-37240

Conversation

@darccio

@darccio darccio commented Apr 15, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Cherry-picks #3429 to v1.73.0 upcoming release.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner April 15, 2025 15:39
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: v1-fix-incident-37240
Commit report: e02b505
Test service: dd-trace-go

✅ 0 Failed, 5506 Passed, 72 Skipped, 10m 35.83s Total Time

@darccio
darccio force-pushed the v1-fix-incident-37240 branch from 056c804 to 756dd23 Compare April 15, 2025 15:48
@darccio
darccio force-pushed the v1-fix-incident-37240 branch from 756dd23 to 73d7699 Compare April 15, 2025 16:24
@pr-commenter

pr-commenter Bot commented Apr 15, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-04-15 16:51:37

Comparing candidate commit 73d7699 in PR branch v1-fix-incident-37240 with baseline commit 60887f3 in branch release-v1.73.x.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 1 unstable metrics.

scenario:BenchmarkStartSpanConcurrent-24

  • 🟩 execution_time [-301.601ns; -117.199ns] or [-5.164%; -2.007%]

@darccio
darccio merged commit 62b0214 into release-v1.73.x Apr 15, 2025
@darccio
darccio deleted the v1-fix-incident-37240 branch April 15, 2025 17:10
darccio added a commit that referenced this pull request Apr 15, 2025
@darccio
fix(ddtrace/tracer): postpone span events/links serialization (#3429) (…
c7774d7 
…#3435)
@darccio darccio mentioned this pull request Apr 16, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@darccio