Skip to content

internal/telemetry: fix telemetry metric submit datarace double pool insertion#3430

Merged
eliottness merged 3 commits into
mainfrom
eliottness/metric-submit-datarace
Apr 15, 2025
Merged

internal/telemetry: fix telemetry metric submit datarace double pool insertion#3430
eliottness merged 3 commits into
mainfrom
eliottness/metric-submit-datarace

Conversation

@eliottness

@eliottness eliottness commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR remove the sync.Pool usage in telemetry metrics because it created a data race

Motivation

Fixes #3413

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: eliottness/metric-submit-datarace
Commit report: 6140cc0
Test service: dd-trace-go

✅ 0 Failed, 4477 Passed, 64 Skipped, 3m 46.8s Total Time

@pr-commenter

pr-commenter Bot commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-04-15 11:35:44

Comparing candidate commit 2c4fddd in PR branch eliottness/metric-submit-datarace with baseline commit 0c4fee3 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 1 unstable metrics.

scenario:BenchmarkOTelApiWithCustomTags/otel_api-24

  • 🟥 allocations [+1; +1] or [+2.273%; +2.273%]

@eliottness
eliottness marked this pull request as ready for review April 15, 2025 10:57
@eliottness
eliottness requested review from a team as code owners April 15, 2025 10:57
@eliottness
remove one more pool allocation
2c4fddd 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness mentioned this pull request Apr 15, 2025
Merged
7 tasks
@eliottness
eliottness enabled auto-merge (squash) April 15, 2025 13:29
@eliottness
eliottness merged commit ad01ccd into main Apr 15, 2025
@eliottness
eliottness deleted the eliottness/metric-submit-datarace branch April 15, 2025 14:06
@tonyredondo tonyredondo mentioned this pull request Apr 15, 2025
Merged
7 tasks
darccio pushed a commit that referenced this pull request Apr 30, 2025
@eliottness @darccio
internal/telemetry: fix telemetry metric submit datarace double pool …
21ddd89 
…insertion (#3430)

Signed-off-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes
@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: Data race in "table" tests with orchestrion

3 participants

@eliottness @tonyredondo @kakkoyun