fix(ddtrace/tracer): postpone span events/links serialization#3429
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 4478 Passed, 64 Skipped, 3m 44.16s Total Time |
felixge
reviewed
Apr 15, 2025
darccio
marked this pull request as ready for review
April 15, 2025 09:52
felixge
approved these changes
Apr 15, 2025
felixge
left a comment
felixge
left a comment
Member
There was a problem hiding this comment.
LGTM. This follows Invariant I and II as outlined in my analysis document. Please backport to v1.
hannahkm
approved these changes
Apr 15, 2025
hannahkm
left a comment
hannahkm
left a comment
Contributor
There was a problem hiding this comment.
lgtm! let's include this in rc5 and keep an eye on things 👍🏼
kakkoyun
approved these changes
Apr 15, 2025
darccio
enabled auto-merge (squash)
April 15, 2025 14:46
darccio
added a commit
that referenced
this pull request
Apr 15, 2025
7 tasks
darccio
added a commit
that referenced
this pull request
Apr 15, 2025
darccio
added a commit
that referenced
this pull request
Apr 15, 2025
darccio
added a commit
that referenced
this pull request
Apr 15, 2025
darccio
added a commit
that referenced
this pull request
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to incident 37240; moves span events/links serialization to later to ensure proper locking is in place when calling these functions.
It also cherry-picks from #3427.
Supersedes #3334.
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!