Skip to content

tracer: Log a warning on NoopTracer.StartSpan() (#2991)#3378

Merged
darccio merged 1 commit into
v2-devfrom
dario.castane/cherrypick-2991
Apr 4, 2025
Merged

tracer: Log a warning on NoopTracer.StartSpan() (#2991)#3378
darccio merged 1 commit into
v2-devfrom
dario.castane/cherrypick-2991

Conversation

@darccio

@darccio darccio commented Apr 4, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Cherrypicks #2991.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@darccio
darccio requested review from a team as code owners April 4, 2025 08:14
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Apr 4, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: dario.castane/cherrypick-2991
Commit report: 594fd17
Test service: dd-trace-go

✅ 0 Failed, 4494 Passed, 65 Skipped, 3m 40.5s Total Time

@darccio
darccio merged commit 24624d3 into v2-dev Apr 4, 2025
@darccio
darccio deleted the dario.castane/cherrypick-2991 branch April 4, 2025 08:53
darccio added a commit that referenced this pull request Apr 4, 2025
mtoffl01 added a commit that referenced this pull request Apr 4, 2025
mtoffl01 added a commit that referenced this pull request Apr 17, 2025
mtoffl01 added a commit that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants