appsec: blocking unavailable + update Envoy contrib#3298
Merged
Conversation
github-actions
Bot
added
the
apm:ecosystem
Datadog ReportBranch report: ✅ 0 Failed, 4477 Passed, 64 Skipped, 3m 47.67s Total Time |
BenchmarksBenchmark execution time: 2025-04-11 15:11:30 Comparing candidate commit 993f327 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 1 unstable metrics. scenario:BenchmarkInjectW3C-24
|
e-n-0
force-pushed
the
flavien/v2/blocking-unavailable
branch
3 times, most recently
from
April 3, 2025 12:27
736d4df to
0e89e4a
Compare
e-n-0
changed the title
e-n-0
marked this pull request as ready for review
April 3, 2025 12:39
e-n-0
force-pushed
the
flavien/v2/blocking-unavailable
branch
2 times, most recently
from
April 8, 2025 14:07
ba7fb4e to
2169f61
Compare
eliottness
reviewed
Apr 8, 2025
e-n-0
force-pushed
the
flavien/v2/blocking-unavailable
branch
from
April 11, 2025 13:40
2169f61 to
7b4f440
Compare
eliottness
approved these changes
Apr 11, 2025
rarguelloF
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_DD_APPSEC_BLOCKING_UNAVAILABLEthat will configure the tracer to not send the blocking capabilities to Remote ConfigDD_SERVICE_EXTENSION_OBSERVABILITY_MODEin the GCP SE callout image that allow to switch to async analysis.Motivation
When running the GCP Service Extension in observability mode (async analysis), it's not possible to block but we still want to get remote rules from RC. Not sending the blocking capabilities will made the backend to only send monitoring rules.
The configuration of appsec from the public tracing package is not possible (only from internal package).
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!