Skip to content

[v2] port #3025 to v2#3147

Merged
hannahkm merged 1 commit into
v2-devfrom
hannahkm/port-dbstats
Feb 4, 2025
Merged

[v2] port #3025 to v2#3147
hannahkm merged 1 commit into
v2-devfrom
hannahkm/port-dbstats

Conversation

@hannahkm

@hannahkm hannahkm commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Ports #3025 to the v2-dev branch. We should clean up dependencies (go get-u and go mod tidy) on the main v2 branch.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 4, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Feb 4, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: hannahkm/port-dbstats
Commit report: 30c218a
Test service: dd-trace-go

✅ 0 Failed, 4101 Passed, 64 Skipped, 1m 34.74s Total Time

@hannahkm
hannahkm marked this pull request as ready for review February 4, 2025 20:37
@hannahkm
hannahkm requested review from a team as code owners February 4, 2025 20:37
@hannahkm
hannahkm marked this pull request as draft February 4, 2025 20:53
@hannahkm
hannahkm force-pushed the hannahkm/port-dbstats branch from 3aae2a0 to 1383824 Compare February 4, 2025 20:56
@hannahkm
hannahkm marked this pull request as ready for review February 4, 2025 21:17
@hannahkm
hannahkm merged commit 1a369a9 into v2-dev Feb 4, 2025
@hannahkm
hannahkm deleted the hannahkm/port-dbstats branch February 4, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant