(fix) internal/civisibility: change http default values and reduce test time (V2)#3135
Merged
Merged
Conversation
7 tasks
anmarchenko
approved these changes
Jan 31, 2025
BenchmarksBenchmark execution time: 2025-01-31 14:49:27 Comparing candidate commit c38f1af in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 1 unstable metrics. |
hannahkm
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the defaults of the CI Visibility http clients, Currently in the worst case scenario the client were blocking the test process up to 60 seconds. This PR reduces this time by changing the constant default values. As a direct impact, this change reduces the time for testing the package.
V1: #3134
Motivation
The current defaults are too large...
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!