Skip to content

(fix) internal/civisibility: change http default values and reduce test time.#3134

Merged
tonyredondo merged 1 commit into
mainfrom
tony/civisibility-change-defaults
Jan 31, 2025
Merged

(fix) internal/civisibility: change http default values and reduce test time.#3134
tonyredondo merged 1 commit into
mainfrom
tony/civisibility-change-defaults

Conversation

@tonyredondo

@tonyredondo tonyredondo commented Jan 31, 2025 •
edited by hannahkm
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This PR changes the defaults of the CI Visibility http clients, Currently in the worst case scenario the client were blocking the test process up to 60 seconds. This PR reduces this time by changing the constant default values. As a direct impact, this change reduces the time for testing the package.

V2: #3135

Motivation

The current defaults are too large...

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@tonyredondo
tonyredondo requested review from a team as code owners January 31, 2025 14:02
@tonyredondo tonyredondo changed the title (feat) internal/civisibility: change http default values and reduce test time. (chore) internal/civisibility: change http default values and reduce test time. Jan 31, 2025
@tonyredondo tonyredondo changed the title (chore) internal/civisibility: change http default values and reduce test time. (fix) internal/civisibility: change http default values and reduce test time. Jan 31, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: tony/civisibility-change-defaults
Commit report: 4b1205b
Test service: dd-trace-go

✅ 0 Failed, 5216 Passed, 72 Skipped, 1m 23.76s Total Time

@tonyredondo tonyredondo mentioned this pull request Jan 31, 2025
Merged
7 tasks
@pr-commenter

pr-commenter Bot commented Jan 31, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-31 14:25:51

Comparing candidate commit b33d550 in PR branch tony/civisibility-change-defaults with baseline commit ddfe2d4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@tonyredondo
tonyredondo force-pushed the tony/civisibility-change-defaults branch from b33d550 to 114c177 Compare January 31, 2025 16:21
@tonyredondo
tonyredondo enabled auto-merge (squash) January 31, 2025 16:21
@tonyredondo
tonyredondo merged commit 7dec46c into main Jan 31, 2025
@tonyredondo
tonyredondo deleted the tony/civisibility-change-defaults branch January 31, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes
@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonyredondo @anmarchenko @hannahkm