Skip to content

Fix peer tags configuration#3132

Merged
darccio merged 2 commits into
mainfrom
ichinaski/fix-peer-tags-config
Feb 3, 2025
Merged

Fix peer tags configuration#3132
darccio merged 2 commits into
mainfrom
ichinaski/fix-peer-tags-config

Conversation

@ichinaski

@ichinaski ichinaski commented Jan 31, 2025 •
edited by hannahkm
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Upon reading the info response from the Agent, we must store the peer_tags internally, which are used for Client-Stats computation.

Motivation

Client-Side Stats require peer tags aggregation. Agent e2e tests revealed that these were missing.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@ichinaski
ichinaski requested a review from a team as a code owner January 31, 2025 11:53
@ichinaski
Fix peer tags configuration
f31e3aa 
Upon reading the info response from the Agent, we must store the
peer_tags internally, which are used for Client-Stats computation.
@ichinaski
ichinaski force-pushed the ichinaski/fix-peer-tags-config branch from efabc19 to f31e3aa Compare January 31, 2025 11:55
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: ichinaski/fix-peer-tags-config
Commit report: 3fc71ff
Test service: dd-trace-go

✅ 0 Failed, 5221 Passed, 72 Skipped, 1m 53.91s Total Time

@pr-commenter

pr-commenter Bot commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-02-03 11:27:50

Comparing candidate commit 7164af2 in PR branch ichinaski/fix-peer-tags-config with baseline commit b143b60 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@ichinaski

ichinaski commented Feb 3, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow

dd-devflow Bot commented Feb 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-02-03 10:05:53 UTC ❌ MergeQueue

You are not allowed to use the merge queue towards main. User is not part of the authorized users or teams.
The authorized teams (including their child teams) are: apm-ecosystems, apm-go, asm-go, profiling-go.
The authorized users are: dbenamydd.

@darccio
darccio enabled auto-merge (squash) February 3, 2025 11:26
@darccio
darccio merged commit 0a41ffd into main Feb 3, 2025
@darccio
darccio deleted the ichinaski/fix-peer-tags-config branch February 3, 2025 11:42
hannahkm pushed a commit that referenced this pull request Feb 4, 2025
@ichinaski @darccio @hannahkm
Fix peer tags configuration (#3132)
9d54846 
Co-authored-by: Dario Castañé <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes
@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ichinaski @ajgajg1134 @hannahkm @darccio