Skip to content

tracer/stats: Only get CI tags when CI Visibility is enabled#3129

Merged
kakkoyun merged 2 commits into
mainfrom
andrew.glaude/ciVizStats
Jan 31, 2025
Merged

tracer/stats: Only get CI tags when CI Visibility is enabled#3129
kakkoyun merged 2 commits into
mainfrom
andrew.glaude/ciVizStats

Conversation

@ajgajg1134

@ajgajg1134 ajgajg1134 commented Jan 29, 2025 •
edited by hannahkm
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Only fetch the git commit sha when CI visibility is enabled.

Motivation

Fetching (And therefore initializing) the CI tags here can create subprocesses and incur a performance cost or create SIGCHLD issues. Given this tag only exists when inside CI Visibility we can safely not attach it when CI Visibility is disabled.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@ajgajg1134
ajgajg1134 requested a review from a team as a code owner January 29, 2025 21:46
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew.glaude/ciVizStats
Commit report: dcdd2e4
Test service: dd-trace-go

✅ 0 Failed, 5216 Passed, 72 Skipped, 2m 48.71s Total Time

@pr-commenter

pr-commenter Bot commented Jan 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-30 18:23:06

Comparing candidate commit 801c1a5 in PR branch andrew.glaude/ciVizStats with baseline commit ddfe2d4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@kakkoyun
kakkoyun merged commit ec054a5 into main Jan 31, 2025
@kakkoyun
kakkoyun deleted the andrew.glaude/ciVizStats branch January 31, 2025 13:38
mtoffl01 pushed a commit that referenced this pull request Feb 3, 2025
@ajgajg1134 @mtoffl01
tracer/stats: Only get CI tags when CI Visibility is enabled (#3129)
6ffc63d
@mtoffl01 mtoffl01 mentioned this pull request Feb 3, 2025
Merged
7 tasks
@nsrip-dd nsrip-dd mentioned this pull request Feb 3, 2025
Merged
7 tasks
hannahkm pushed a commit that referenced this pull request Feb 4, 2025
@ajgajg1134 @hannahkm
tracer/stats: Only get CI tags when CI Visibility is enabled (#3129)
4d855f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes
@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajgajg1134 @tonyredondo @kakkoyun