ddtrace/tracer: Fix panic on Extract when DD_TRACE_PROPAGATION_EXTRACT_FIRST=true and no trace headers present#3128
Merged
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5220 Passed, 73 Skipped, 1m 22.33s Total Time |
mtoffl01
changed the title
mtoffl01
marked this pull request as ready for review
January 29, 2025 21:56
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mtoffl01
enabled auto-merge (squash)
January 31, 2025 18:14
mtoffl01
added a commit
that referenced
this pull request
Feb 3, 2025
…T_FIRST=true and no trace headers present (#3128)
mtoffl01
added a commit
that referenced
this pull request
Feb 3, 2025
…T_FIRST=true and no trace headers present (#3128)
7 tasks
hannahkm
pushed a commit
that referenced
this pull request
Feb 4, 2025
…XTRACT_FIRST=true and no trace headers present (#3128)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a panic caused by this line of code:
return extractedCtx.(*spanContext), nil, whenextractedCtxisnil.Motivation
Bug was detected when configuring
DD_TRACE_PROPAGATION_EXTRACT_FIRST=trueand no tracing-related keys are found in carrier. To reproduce this, you can paste theTestExtractNoHeadersto the v1.71.0 branch and watch it panic.Bug was introduced in v1.71.0 as a result of this PR.
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!