feat: implement origin detection#3124
Merged
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5222 Passed, 73 Skipped, 1m 55.7s Total Time |
BenchmarksBenchmark execution time: 2025-02-05 15:17:35 Comparing candidate commit 2c8524e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
darccio
force-pushed
the
dario.castane/langplat-286/origin-detection
branch
from
January 28, 2025 15:47
814d0ba to
fa2f8ba
Compare
…ing in the right environment
darccio
force-pushed
the
dario.castane/langplat-286/origin-detection
branch
2 times, most recently
from
February 3, 2025 15:29
4d1fceb to
e657fc8
Compare
darccio
marked this pull request as ready for review
February 3, 2025 15:29
Member
Author
|
system-Tests covering this feature are in progress, but I'm waiting on some help as this feature depends on environment variables and it doesn't seem to be a good way to test these cases in |
darccio
force-pushed
the
dario.castane/langplat-286/origin-detection
branch
2 times, most recently
from
February 5, 2025 11:18
b2a9fc1 to
e657fc8
Compare
kakkoyun
approved these changes
Feb 5, 2025
darccio
enabled auto-merge (squash)
February 5, 2025 13:30
darccio
disabled auto-merge
February 5, 2025 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Origin Detection is a feature that allows the Agent to correctly detect and tag incoming custom metrics or traces with their Origin (AKA container tags).
Origin Detection works by having the client sending additional data to the Agent so the Agent is able to resolve the Origin.
This PR implements the missing external data implementation. External data was implemented as a last resort for Origin Detection in case no other solution would work.
It also updates the
cid-prefix for the container ID according to the current state of Origin Detection as described in the task's RFC.Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!