Skip to content

contrib/gorm.io/gorm.v1: fix orchestrion aspect#3121

Merged
rarguelloF merged 5 commits into
mainfrom
rarguelloF/fix-gorm-orchestrion-issue
Feb 3, 2025
Merged

contrib/gorm.io/gorm.v1: fix orchestrion aspect#3121
rarguelloF merged 5 commits into
mainfrom
rarguelloF/fix-gorm-orchestrion-issue

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes DataDog/orchestrion#511

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 27, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: rarguelloF/fix-gorm-orchestrion-issue
Commit report: c1e3157
Test service: dd-trace-go

✅ 0 Failed, 5221 Passed, 72 Skipped, 2m 7.43s Total Time

@pr-commenter

pr-commenter Bot commented Jan 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-02-03 09:19:48

Comparing candidate commit b621f95 in PR branch rarguelloF/fix-gorm-orchestrion-issue with baseline commit 2ee7731 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@rarguelloF
rarguelloF marked this pull request as ready for review January 30, 2025 09:28
@rarguelloF
rarguelloF requested review from a team as code owners January 30, 2025 09:28
@rarguelloF
rarguelloF enabled auto-merge (squash) January 30, 2025 09:28
@rarguelloF
rarguelloF merged commit b143b60 into main Feb 3, 2025
@rarguelloF
rarguelloF deleted the rarguelloF/fix-gorm-orchestrion-issue branch February 3, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Auto instrumentation with gorm fails

3 participants

@rarguelloF @darccio @RomainMuller