Skip to content

github action: change semver detection for Service Extension#3117

Merged
eliottness merged 1 commit into
mainfrom
flavien/fix-detection-release-semver
Jan 24, 2025
Merged

github action: change semver detection for Service Extension#3117
eliottness merged 1 commit into
mainfrom
flavien/fix-detection-release-semver

Conversation

@e-n-0

@e-n-0 e-n-0 commented Jan 24, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Change the detection of a release to publish a new Service Extension image.
This changes will only detect full release of the Go tracer (excluding all release candidates, dev, pre-release).

Motivation

New changes in the tags during the development of the Go tracer breaks the detection of a new release for publishing new image of Service Extensions.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 requested review from a team as code owners January 24, 2025 15:09
@eliottness
eliottness enabled auto-merge (squash) January 24, 2025 15:12
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Report

Branch report: flavien/fix-detection-release-semver
Commit report: e13ac66
Test service: dd-trace-go

✅ 0 Failed, 5206 Passed, 73 Skipped, 2m 20.17s Total Time

@pr-commenter

pr-commenter Bot commented Jan 24, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-24 15:34:17

Comparing candidate commit 643e93c in PR branch flavien/fix-detection-release-semver with baseline commit 9f1ce94 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@eliottness
eliottness merged commit ef2e4e2 into main Jan 24, 2025
@eliottness
eliottness deleted the flavien/fix-detection-release-semver branch January 24, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants