Skip to content

Add Service Extensions system tests to CI#3112

Merged
eliottness merged 1 commit into
mainfrom
flavien/envoy/enable-system-tests
Jan 23, 2025
Merged

Add Service Extensions system tests to CI#3112
eliottness merged 1 commit into
mainfrom
flavien/envoy/enable-system-tests

Conversation

@e-n-0

@e-n-0 e-n-0 commented Jan 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Add the Service Extensions system tests scenarios to the CI.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 requested review from a team as code owners January 22, 2025 16:35
@e-n-0
e-n-0 marked this pull request as draft January 22, 2025 16:35
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: flavien/envoy/enable-system-tests
Commit report: c22252c
Test service: dd-trace-go

✅ 0 Failed, 5201 Passed, 72 Skipped, 2m 19.4s Total Time

@e-n-0
e-n-0 marked this pull request as ready for review January 22, 2025 16:45
@eliottness
eliottness enabled auto-merge (squash) January 22, 2025 16:57
@pr-commenter

pr-commenter Bot commented Jan 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-23 23:35:51

Comparing candidate commit ba55d87 in PR branch flavien/envoy/enable-system-tests with baseline commit 700f43e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the flavien/envoy/enable-system-tests branch from d88582c to ba55d87 Compare January 23, 2025 23:08
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 23, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: flavien/envoy/enable-system-tests
Commit report: a0ef2fd
Test service: dd-trace-go

✅ 0 Failed, 5207 Passed, 72 Skipped, 2m 47.27s Total Time

@eliottness
eliottness merged commit 9f1ce94 into main Jan 23, 2025
@eliottness
eliottness deleted the flavien/envoy/enable-system-tests branch January 23, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e-n-0 @darccio @eliottness