contrib/IBM/sarama.v1: stop using mockbroker for tests#3104
Merged
Conversation
github-actions
Bot
added
the
apm:ecosystem
rarguelloF
force-pushed
the
rarguelloF/integration-tests-sarama
branch
from
January 20, 2025 14:42
bc8b350 to
a33040c
Compare
Datadog ReportBranch report: ✅ 0 Failed, 3011 Passed, 25 Skipped, 2m 19.26s Total Time |
BenchmarksBenchmark execution time: 2025-01-20 16:46:17 Comparing candidate commit f7d2f03 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
rarguelloF
enabled auto-merge (squash)
January 20, 2025 16:21
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change tests of
IBM/saramato use a real kafka broker instead of usingsarama.NewMockBroker.Motivation
The behavior of the mock broker has changed in future versions of IBM/sarama, which makes our v2 smoke tests fail. Instead of trying to hunt what changed and how to fix our tests with the new mock broker behavior, its better and more reliable to test things with an actual Kafka instance (which is how we test the rest of our Kafka integrations).
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!