Skip to content

internal/telemetry: revert hostname.Get() -> os.Hostname()#3101

Merged
eliottness merged 1 commit into
mainfrom
eliottness/revert-hostname-telemetry
Jan 20, 2025
Merged

internal/telemetry: revert hostname.Get() -> os.Hostname()#3101
eliottness merged 1 commit into
mainfrom
eliottness/revert-hostname-telemetry

Conversation

@eliottness

@eliottness eliottness commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: eliottness/revert-hostname-telemetry
Commit report: 104b869
Test service: dd-trace-go

✅ 0 Failed, 5189 Passed, 72 Skipped, 2m 39.66s Total Time

@eliottness
eliottness force-pushed the eliottness/revert-hostname-telemetry branch from 9ab2120 to 278b888 Compare January 17, 2025 16:14
@pr-commenter

pr-commenter Bot commented Jan 17, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-17 16:41:15

Comparing candidate commit 278b888 in PR branch eliottness/revert-hostname-telemetry with baseline commit 382c311 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 57 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagMetric-24

  • 🟥 execution_time [+2.656ns; +5.144ns] or [+2.239%; +4.337%]

scenario:BenchmarkSetTagStringPtr-24

  • 🟥 execution_time [+5.388ns; +9.552ns] or [+3.147%; +5.579%]

@eliottness
eliottness marked this pull request as ready for review January 20, 2025 09:24
@eliottness
eliottness requested review from a team as code owners January 20, 2025 09:24
@eliottness
eliottness merged commit 2e3193f into main Jan 20, 2025
@eliottness
eliottness deleted the eliottness/revert-hostname-telemetry branch January 20, 2025 09:27
darccio
darccio reviewed Jan 20, 2025
View reviewed changes
Comment thread internal/telemetry/client.go
RomainMuller pushed a commit that referenced this pull request Jan 20, 2025
@eliottness @RomainMuller
internal/telemetry: revert hostname.Get() -> os.Hostname() (#3101)
7a2fbad 
Signed-off-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio left review comments
@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @darccio @RomainMuller