appsec: change log WAF 'too many event' from Warn to Error#3100
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5185 Passed, 72 Skipped, 2m 32.11s Total Time |
eliottness
approved these changes
Jan 17, 2025
e-n-0
force-pushed
the
flavien/appsec-on-error
branch
from
January 17, 2025 15:29
598a6fa to
1f71193
Compare
eliottness
enabled auto-merge (squash)
January 17, 2025 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the log of too many Appsec WAF event from Warn to Error.
Motivation
The log can be sometimes spammy (cf run inside macrobenchmarks). Setting this log to Error can use the deduplication of errors.
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!