Skip to content

appsec: meta_struct Security Events#3098

Merged
eliottness merged 3 commits into
mainfrom
eliottness/APPSEC-53213/meta-struct
Jan 17, 2025
Merged

appsec: meta_struct Security Events#3098
eliottness merged 3 commits into
mainfrom
eliottness/APPSEC-53213/meta-struct

Conversation

@eliottness

@eliottness eliottness commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR implement the Security events in meta struct RFC

Motivation

  • Delegate security events serialization in the trace writer goroutine
  • Simplify EVP Track backend-side

Reviewer's Checklist

System-tests run: https://github.com/DataDog/dd-trace-go/actions/runs/12827599264

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: eliottness/APPSEC-53213/meta-struct
Commit report: 8951799
Test service: dd-trace-go

✅ 0 Failed, 5185 Passed, 72 Skipped, 2m 54.98s Total Time

@pr-commenter

pr-commenter Bot commented Jan 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-17 13:31:07

Comparing candidate commit 973174c in PR branch eliottness/APPSEC-53213/meta-struct with baseline commit 9a8062c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@eliottness
eliottness marked this pull request as ready for review January 17, 2025 12:41
@eliottness
eliottness requested review from a team as code owners January 17, 2025 12:41
@eliottness
eliottness force-pushed the eliottness/APPSEC-53213/meta-struct branch from a4ad271 to 973174c Compare January 17, 2025 12:47
darccio
darccio approved these changes Jan 17, 2025
View reviewed changes

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliottness
test meta_struct support
cd31a37 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
eliottness enabled auto-merge (squash) January 17, 2025 14:35
@eliottness
eliottness merged commit f5b85c2 into main Jan 17, 2025
@eliottness
eliottness deleted the eliottness/APPSEC-53213/meta-struct branch January 17, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

appsec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @darccio @RomainMuller