chore(lint): Add "go vet" to golangci-lint#3095
Merged
Merged
Conversation
Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
marked this pull request as draft
January 16, 2025 15:55
Datadog ReportBranch report: ✅ 0 Failed, 5181 Passed, 71 Skipped, 2m 54.18s Total Time |
BenchmarksBenchmark execution time: 2025-01-16 17:36:53 Comparing candidate commit 9666888 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
darccio
approved these changes
Jan 16, 2025
kakkoyun
marked this pull request as ready for review
January 16, 2025 16:52
Member
|
@kakkoyun You can update the branch and merge this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun [email protected]
What does this PR do?
This PR enables
go vetfor the static checks of the codebase.Motivation
go vetis a tool that reports suspicious constructs in Go code as part of stadard Go tooling.It is a static analysis tool that checks for common mistakes in the code.
It is a good practice to run
go vetbefore submitting a PR to catch potential issues early.Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!