Skip to content

contrib/IBM/sarama.v1: skip integration test if env variable is not set#3092

Merged
hannahkm merged 1 commit into
mainfrom
rarguelloF/ibm-sarama-skip-integration-test
Jan 16, 2025
Merged

contrib/IBM/sarama.v1: skip integration test if env variable is not set#3092
hannahkm merged 1 commit into
mainfrom
rarguelloF/ibm-sarama-skip-integration-test

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Skip IBM/sarama.v1 integration test if INTEGRATION env variable is not set.

Motivation

Smoke tests fail because they run the contrib tests without starting the dependent containers.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@rarguelloF
rarguelloF requested review from a team as code owners January 16, 2025 14:18
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 16, 2025
@rarguelloF rarguelloF mentioned this pull request Jan 16, 2025
Merged
7 tasks
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: rarguelloF/ibm-sarama-skip-integration-test
Commit report: 7ec5f70
Test service: dd-trace-go

✅ 0 Failed, 5174 Passed, 71 Skipped, 2m 35.45s Total Time

@pr-commenter

pr-commenter Bot commented Jan 16, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-16 15:02:23

Comparing candidate commit c3c1801 in PR branch rarguelloF/ibm-sarama-skip-integration-test with baseline commit c27f098 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@hannahkm
hannahkm merged commit 2671ec0 into main Jan 16, 2025
@hannahkm
hannahkm deleted the rarguelloF/ibm-sarama-skip-integration-test branch January 16, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rarguelloF @hannahkm