Skip to content

contrib/envoyproxy: fix empty request#3089

Merged
eliottness merged 3 commits into
mainfrom
flavien/envoy/fix-envoy-error-handling
Jan 15, 2025
Merged

contrib/envoyproxy: fix empty request#3089
eliottness merged 3 commits into
mainfrom
flavien/envoy/fix-envoy-error-handling

Conversation

@e-n-0

@e-n-0 e-n-0 commented Jan 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This PR fixes an issue that could cause a crash when a response was processed without any corresponding request being received.

This can happen when Envoy fails to send a request headers processing and only send the processing of the response.

Related issue opened in the envoy repo: envoyproxy/envoy#38022

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 requested review from a team as code owners January 15, 2025 16:06
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 15, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: flavien/envoy/fix-envoy-error-handling
Commit report: 6da76a9
Test service: dd-trace-go

✅ 0 Failed, 5174 Passed, 71 Skipped, 2m 33.12s Total Time

eliottness
eliottness approved these changes Jan 15, 2025
View reviewed changes
Comment thread contrib/envoyproxy/go-control-plane/envoy.go Outdated
@eliottness
eliottness enabled auto-merge (squash) January 15, 2025 17:17
@eliottness
eliottness merged commit 56c1875 into main Jan 15, 2025
@eliottness
eliottness deleted the flavien/envoy/fix-envoy-error-handling branch January 15, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e-n-0 @darccio @eliottness