(fix) internal/civisibility: add some checks before performing the http requests.#3087
Merged
Merged
Conversation
…quests and also add support for sending code coverage data in a different format.
Datadog ReportBranch report: ✅ 0 Failed, 5170 Passed, 70 Skipped, 2m 35.36s Total Time |
daniel-mohedano
approved these changes
Jan 15, 2025
BenchmarksBenchmark execution time: 2025-01-15 13:23:03 Comparing candidate commit eec56c7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
darccio
approved these changes
Jan 15, 2025
Comment on lines
+47
to
+63
| if format == FormatMessagePack { | ||
| coverageEvent = FormFile{ | ||
| FieldName: "coveragex", | ||
| Content: ciTestCovPayload, | ||
| FileName: "filecoveragex.msgpack", | ||
| ContentType: ContentTypeMessagePack, | ||
| } | ||
| } else if format == FormatJSON { | ||
| coverageEvent = FormFile{ | ||
| FieldName: "coveragex", | ||
| Content: ciTestCovPayload, | ||
| FileName: "filecoveragex.json", | ||
| ContentType: ContentTypeJSON, | ||
| } | ||
| } else { | ||
| return fmt.Errorf("unsupported format: %s", format) | ||
| } |
Member
There was a problem hiding this comment.
nit: this could be a bit cleaner with a switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add some checks before performing the http requests and also add support for sending code coverage data in a different format.
PR for V2: #3088
Motivation
I saw some http client response with status code 400 when testing on a Go project without a git repo.
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!