(fix) internal/civisibility/utils: improve environment tags mutability#3076
Merged
tonyredondo merged 1 commit intoJan 13, 2025
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5127 Passed, 70 Skipped, 2m 27.75s Total Time |
7 tasks
tonyredondo
force-pushed
the
tony/civisibility-improve-environment-tags-mutability
branch
from
January 10, 2025 16:19
9531f7b to
35f1c3c
Compare
tonyredondo
marked this pull request as ready for review
January 10, 2025 16:19
tonyredondo
force-pushed
the
tony/civisibility-improve-environment-tags-mutability
branch
from
January 10, 2025 16:33
35f1c3c to
c5e1990
Compare
BenchmarksBenchmark execution time: 2025-01-10 17:16:04 Comparing candidate commit c5e1990 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 57 metrics, 1 unstable metrics. scenario:BenchmarkSetTagString-24
|
darccio
approved these changes
Jan 13, 2025
Member
|
No impact on reported benchmarks. The PR looks fine. |
juan-fernandez
approved these changes
Jan 13, 2025
tonyredondo
deleted the
tony/civisibility-improve-environment-tags-mutability
branch
January 13, 2025 11:09
hannahkm
pushed a commit
that referenced
this pull request
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves the mutability over the environment tags, avoiding to re-running the Cmds (git commands) after adding new tags and avoiding race conditions.
Same PR for v2-dev: #3077
Ticket: SDTEST-1424
Motivation
Currently if we add a new tag we end up by re running the git command to create a new map, this PR fixes this issue.
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!