Skip to content

contrib/IBM/sarama.v1: remove commented code#3073

Merged
hannahkm merged 1 commit into
mainfrom
rarguelloF/remove-comments
Jan 9, 2025
Merged

contrib/IBM/sarama.v1: remove commented code#3073
hannahkm merged 1 commit into
mainfrom
rarguelloF/remove-comments

Conversation

@rarguelloF

Copy link
Copy Markdown
Contributor

What does this PR do?

Remove commented code I missed from #3041

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@rarguelloF
rarguelloF requested review from a team as code owners January 9, 2025 13:47
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 9, 2025
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Report

Branch report: rarguelloF/remove-comments
Commit report: 25869af
Test service: dd-trace-go

✅ 0 Failed, 5122 Passed, 70 Skipped, 2m 35.87s Total Time

@pr-commenter

pr-commenter Bot commented Jan 9, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-09 14:31:14

Comparing candidate commit 43046d3 in PR branch rarguelloF/remove-comments with baseline commit 38c3f21 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@hannahkm
hannahkm merged commit 6a2ad62 into main Jan 9, 2025
@hannahkm
hannahkm deleted the rarguelloF/remove-comments branch January 9, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants