contrib/net/http: Obfuscate query strings on http client spans#3071
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5174 Passed, 70 Skipped, 2m 39.68s Total Time |
BenchmarksBenchmark execution time: 2025-01-09 22:16:15 Comparing candidate commit 0e18bc4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
darccio
approved these changes
Jan 15, 2025
mtoffl01
enabled auto-merge (squash)
January 15, 2025 15:55
mtoffl01
disabled auto-merge
January 15, 2025 16:00
7 tasks
7 tasks
darccio
added a commit
that referenced
this pull request
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Passes tests in: DataDog/system-tests#3783
Motivation
Http server spans already benefited from both of the above behaviors. Now, http client spans can too (safely).
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!