Skip to content

contrib/net/http: Obfuscate query strings on http client spans#3071

Merged
mtoffl01 merged 6 commits into
mainfrom
mtoff/obfuscate-client-querystr
Jan 15, 2025
Merged

contrib/net/http: Obfuscate query strings on http client spans#3071
mtoffl01 merged 6 commits into
mainfrom
mtoff/obfuscate-client-querystr

Conversation

@mtoffl01

@mtoffl01 mtoffl01 commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Passes tests in: DataDog/system-tests#3783

Motivation

Http server spans already benefited from both of the above behaviors. Now, http client spans can too (safely).

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 8, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 8, 2025

Copy link
Copy Markdown

Datadog Report

Branch report: mtoff/obfuscate-client-querystr
Commit report: e81a4e8
Test service: dd-trace-go

✅ 0 Failed, 5174 Passed, 70 Skipped, 2m 39.68s Total Time

@pr-commenter

pr-commenter Bot commented Jan 8, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-09 22:16:15

Comparing candidate commit 0e18bc4 in PR branch mtoff/obfuscate-client-querystr with baseline commit 6a2ad62 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@mtoffl01
mtoffl01 marked this pull request as ready for review January 9, 2025 21:33
@mtoffl01
mtoffl01 requested review from a team as code owners January 9, 2025 21:33
@mtoffl01
mtoffl01 requested a review from RomainMuller January 14, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants