Skip to content

internal/appsec: add fingerprint tests#3068

Merged
eliottness merged 1 commit into
mainfrom
eliottness/add-fp-tests
Jan 8, 2025
Merged

internal/appsec: add fingerprint tests#3068
eliottness merged 1 commit into
mainfrom
eliottness/add-fp-tests

Conversation

@eliottness

Copy link
Copy Markdown
Contributor

What does this PR do?

Add more fingerprint tests from a buggy env
spoiler: the bug was not found yet

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@eliottness
eliottness requested review from a team as code owners January 8, 2025 14:50
@eliottness
eliottness force-pushed the eliottness/add-fp-tests branch from ece54c5 to 1fff001 Compare January 8, 2025 14:51
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Report

Branch report: eliottness/add-fp-tests
Commit report: 1b3c5bb
Test service: dd-trace-go

✅ 0 Failed, 5121 Passed, 70 Skipped, 2m 35.38s Total Time

@pr-commenter

pr-commenter Bot commented Jan 8, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-08 15:35:47

Comparing candidate commit 1fff001 in PR branch eliottness/add-fp-tests with baseline commit e460de6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@eliottness
eliottness merged commit 3647944 into main Jan 8, 2025
@eliottness
eliottness deleted the eliottness/add-fp-tests branch January 8, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants