fix: workaround for otel agent dependency causes orchestrion failure#3066
Merged
Conversation
Moved the blank import of `go.opentelemetry.io/collector/pdata/pprofile`` which was introduced to avoid `go mod tidy` from failing to resolve a coherent dependency closure into a new file guarded by a build tag so that it is not present in builds uder normal circumstances. This removes a dependency cycle caused by the `pprofile` package having a transitive dependency on `net/http`, while the `gopkg.in/DataDog/dd-trace-go.v1/internal` package is imported some code that is injected by orchestrion into `net/http` itself (resulting in a cycle, breaking builds).
Datadog ReportBranch report: ✅ 0 Failed, 5121 Passed, 70 Skipped, 2m 53.05s Total Time |
RomainMuller
approved these changes
Jan 6, 2025
hannahkm
pushed a commit
that referenced
this pull request
Jan 6, 2025
darccio
added a commit
that referenced
this pull request
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moved the blank import of
go.opentelemetry.io/collector/pdata/pprofilewhich was introduced to avoidgo mod tidyfrom failing to resolve a coherent dependency closure into a new file guarded by a build tag so that it is not present in builds under normal circumstances.This removes a dependency cycle caused by the
pprofilepackage having a transitive dependency onnet/http, while thegopkg.in/DataDog/dd-trace-go.v1/internalpackage is imported some code that is injected by orchestrion intonet/httpitself (resulting in a cycle, breaking builds).Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!