Skip to content

internal/remoteconfig: support for DD_REMOTE_CONFIGURATION_ENABLED#3063

Merged
eliottness merged 1 commit into
mainfrom
eliottness/DD_REMOTE_CONFIGURATION_ENABLED
Jan 7, 2025
Merged

internal/remoteconfig: support for DD_REMOTE_CONFIGURATION_ENABLED#3063
eliottness merged 1 commit into
mainfrom
eliottness/DD_REMOTE_CONFIGURATION_ENABLED

Conversation

@eliottness

@eliottness eliottness commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Introduces a new env var called DD_REMOTE_CONFIGURATION_ENABLED to disable remote config client side.

Motivation

Closes #3060

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@eliottness eliottness mentioned this pull request Jan 2, 2025
Closed
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: eliottness/DD_REMOTE_CONFIGURATION_ENABLED
Commit report: 6cde583
Test service: dd-trace-go

✅ 0 Failed, 5121 Passed, 70 Skipped, 2m 54.57s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • TestExchangeContext - gopkg.in/DataDog/dd-trace-go.v1/contrib/miekg/dns

@pr-commenter

pr-commenter Bot commented Jan 2, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-02 11:08:22

Comparing candidate commit d9ea482 in PR branch eliottness/DD_REMOTE_CONFIGURATION_ENABLED with baseline commit 4f57a47 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@eliottness
eliottness marked this pull request as ready for review January 6, 2025 14:47
@eliottness
eliottness requested review from a team as code owners January 6, 2025 14:47
@eliottness
eliottness enabled auto-merge (squash) January 6, 2025 14:47
@eliottness
eliottness force-pushed the eliottness/DD_REMOTE_CONFIGURATION_ENABLED branch from d9ea482 to 0fccfa1 Compare January 7, 2025 18:47
@eliottness
eliottness merged commit e460de6 into main Jan 7, 2025
@eliottness
eliottness deleted the eliottness/DD_REMOTE_CONFIGURATION_ENABLED branch January 7, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Does dd-trace-go/tracer support DD_REMOTE_CONFIGURATION_ENABLED?

2 participants

@eliottness @darccio