Skip to content

fix(ddtrace/tracer): fix panic in SQLCommentCarrier#3062

Merged
darccio merged 3 commits into
mainfrom
rarguelloF/fix-sqlcomment-panic
Jan 10, 2025
Merged

fix(ddtrace/tracer): fix panic in SQLCommentCarrier#3062
darccio merged 3 commits into
mainfrom
rarguelloF/fix-sqlcomment-panic

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Dec 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #2837

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: rarguelloF/fix-sqlcomment-panic
Commit report: ecdfa08
Test service: dd-trace-go

❌ 1 Failed (0 Known Flaky), 5122 Passed, 70 Skipped, 2m 32.96s Total Time

❌ Failed Tests (1)

  • TestExchangeConn - gopkg.in/DataDog/dd-trace-go.v1/contrib/miekg/dns - Details

    Expand for error 
     Failed
 
 === RUN   TestExchangeConn
     dns_test.go:47: listen udp 127.0.0.1:2020: bind: address already in use
 dns: ExchangeConn: this function is deprecated
     dns_test.go:105: 
         	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/miekg/dns/dns_test.go:105
         	Error:      	Received unexpected error:
         	            	read udp 127.0.0.1:39852->127.0.0.1:2020: read: connection refused
         	Test:       	TestExchangeConn
 ...

darccio
darccio requested changes Jan 7, 2025
View reviewed changes
Comment thread ddtrace/tracer/spancontext.go Outdated
@rarguelloF
rarguelloF marked this pull request as ready for review January 9, 2025 12:42
@rarguelloF
rarguelloF requested a review from a team as a code owner January 9, 2025 12:42
@rarguelloF
rarguelloF requested a review from darccio January 9, 2025 12:42
@pr-commenter

pr-commenter Bot commented Jan 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-10 13:53:38

Comparing candidate commit 055e8c6 in PR branch rarguelloF/fix-sqlcomment-panic with baseline commit 6a2ad62 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 1 unstable metrics.

scenario:BenchmarkSetTagString-24

  • 🟩 execution_time [-5.803ns; -3.297ns] or [-4.769%; -2.709%]

scenario:BenchmarkSetTagStringer-24

  • 🟩 execution_time [-8.814ns; -5.706ns] or [-5.957%; -3.856%]

@darccio
darccio enabled auto-merge (squash) January 10, 2025 13:10
@darccio
darccio merged commit d5b23f5 into main Jan 10, 2025
@darccio
darccio deleted the rarguelloF/fix-sqlcomment-panic branch January 10, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Fatal issue in sqlcomment.go

2 participants

@rarguelloF @darccio