Skip to content

repo: mandatory issue templates (AIDM-425)#3046

Merged
tlhunter merged 1 commit into
mainfrom
tlhunter/create-issue-standard
Jan 21, 2025
Merged

repo: mandatory issue templates (AIDM-425)#3046
tlhunter merged 1 commit into
mainfrom
tlhunter/create-issue-standard

Conversation

@tlhunter

@tlhunter tlhunter commented Dec 18, 2024

Copy link
Copy Markdown
Member

What does this PR do?

  • repurposes the freeform issue templates to versions with UI elements
  • makes issue templates mandatory
  • links to helpdesk pages

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@tlhunter tlhunter added enhancement quick change/addition that does not need full team approval docs no-changelog changelog/no-changelog labels Dec 18, 2024
@tlhunter
tlhunter requested review from a team as code owners December 18, 2024 00:15
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: tlhunter/create-issue-standard
Commit report: 47e2c70
Test service: dd-trace-go

❌ 1 Failed (1 Known Flaky), 5200 Passed, 72 Skipped, 2m 46.32s Total Time

❌ Failed Tests (1)

  • TestClient_Exchange - gopkg.in/DataDog/dd-trace-go.v1/contrib/miekg/dns - ❄️ Known flaky - Details

    Expand for error 
     Failed
 
 === RUN   TestClient_Exchange
     dns_test.go:47: listen udp 127.0.0.1:2020: bind: address already in use
     dns_test.go:124: 
         	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/miekg/dns/dns_test.go:124
         	Error:      	Received unexpected error:
         	            	read udp 127.0.0.1:41266->127.0.0.1:2020: read: connection refused
         	Test:       	TestClient_Exchange
     dns_test.go:53: 
 ...

@pr-commenter

pr-commenter Bot commented Dec 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-01-21 22:11:27

Comparing candidate commit 0248bb0 in PR branch tlhunter/create-issue-standard with baseline commit e394045 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@tlhunter
tlhunter force-pushed the tlhunter/create-issue-standard branch from 3aa516e to 19234d0 Compare December 18, 2024 22:50
eliottness
eliottness reviewed Dec 19, 2024
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/bug-report.yaml
@tlhunter
tlhunter enabled auto-merge (squash) December 19, 2024 22:00
@eliottness
eliottness requested review from eliottness and removed request for eliottness December 20, 2024 01:36
@tlhunter
tlhunter force-pushed the tlhunter/create-issue-standard branch from 4b9d682 to fb86279 Compare December 23, 2024 16:48
@tlhunter
tlhunter force-pushed the tlhunter/create-issue-standard branch 2 times, most recently from a0cd39d to 0220a6f Compare January 13, 2025 23:18
hannahkm
hannahkm reviewed Jan 21, 2025
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/bug-report.yaml Outdated
- type: input
attributes:
label: Go Version(s)
description: "Version(s) of Go (`go version`) that you've encountered this bug with. If you aren't using the [latest version](https://github.com/DataDog/dd-trace-go/releases) of dd-trace-go, try upgrading first to see if your issue has already been resolved."

@hannahkm hannahkm Jan 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we asking for the version of Golang that they're using, or the version of the Go Tracer? From reading the label and placeholder value, it seems like Golang, but the description implies otherwise.

@tlhunter
repo: mandatory issue templates
0248bb0 
replace OS with go env

rename config file

update text

move upgrade note from go version to tracer version
@tlhunter
tlhunter force-pushed the tlhunter/create-issue-standard branch from 0220a6f to 0248bb0 Compare January 21, 2025 21:44
@tlhunter
tlhunter merged commit fcf044d into main Jan 21, 2025
@tlhunter
tlhunter deleted the tlhunter/create-issue-standard branch January 21, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio left review comments
@eliottness eliottness eliottness left review comments
@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog docs enhancement quick change/addition that does not need full team approval no-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tlhunter @darccio @hannahkm @eliottness