contrib/IBM/sarama.v1: support for consumer groups#3041
Merged
Conversation
github-actions
Bot
added
the
apm:ecosystem
Datadog ReportBranch report: ✅ 0 Failed, 5122 Passed, 70 Skipped, 2m 34.32s Total Time |
BenchmarksBenchmark execution time: 2024-12-19 12:58:24 Comparing candidate commit c2088e0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
rarguelloF
marked this pull request as ready for review
December 19, 2024 10:43
darccio
approved these changes
Dec 20, 2024
darccio
left a comment
darccio
left a comment
Member
There was a problem hiding this comment.
LGTM.
@rarguelloF Remember to port this to v2-dev.
This was referenced Jan 9, 2025
|
Hi team, when we are planning to release this support ? I could not find this commit in the latest release tag v1.71.0. |
Member
|
@harshit98 It'll be released in our February's release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for instrumenting consumer groups for
IBM/saramathrough wrappingsarama.ConsumerGroupHandler.Closes #2133, closes #552, closes #1928
Motivation
Support tracing consumer groups.
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!