Skip to content

go.mod: point to latest pseudo-version#3014

Merged
felixge merged 1 commit into
anatoleb/runtime-metrics-use-direct-clientfrom
felix.geisendoerfer/runtime-metrics-use-direct-client
Dec 6, 2024
Merged

go.mod: point to latest pseudo-version#3014
felixge merged 1 commit into
anatoleb/runtime-metrics-use-direct-clientfrom
felix.geisendoerfer/runtime-metrics-use-direct-client

Conversation

@felixge

@felixge felixge commented Dec 6, 2024

Copy link
Copy Markdown
Member

See DataDog/go-runtime-metrics-internal#10 (comment)

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@felixge
felixge requested a review from anatolebeuzon December 6, 2024 09:18
@pr-commenter

pr-commenter Bot commented Dec 6, 2024

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2024-12-06 09:59:25

Comparing candidate commit b13f354 in PR branch felix.geisendoerfer/runtime-metrics-use-direct-client with baseline commit 9beb947 in branch anatoleb/runtime-metrics-use-direct-client.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@felixge felixge changed the title ddtrace/tracer: initialize runtimeMetricsV2 with statsd "direct" client go.mod: point to latest pseudo-version Dec 6, 2024
@felixge
felixge merged commit 32eacc7 into anatoleb/runtime-metrics-use-direct-client Dec 6, 2024
@felixge
felixge deleted the felix.geisendoerfer/runtime-metrics-use-direct-client branch December 6, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant