fix(.github/workflows): add tags-ignore to avoid running CI on pushing tags for contribs and other nested modules#3005
Conversation
034574c to
74620b4
Compare
nsrip-dd
left a comment
nsrip-dd
left a comment
There was a problem hiding this comment.
dd-trace-go@v2 has 50+ tags per release, so pushing them generate a lot of workload in CI.
If I understand correctly, this is because there will be seperate modules for each contrib/integration, which we need to tag seperately? But the tags will all point to the same code, right? If so, definitely makes sense not to run redundant CI on those tags.
| tags-ignore: | ||
| - 'contrib/**' | ||
| - 'instrumentation/**' |
There was a problem hiding this comment.
So these checks would still run on all PRs, but not for each pushed tag, right?
Datadog ReportBranch report: ✅ 0 Failed, 5110 Passed, 67 Skipped, 2m 53.89s Total Time |
Indeed, @nsrip-dd, this is the case. Although the process involves tagging and pushing tags in three phases (1, tag the root module; 2, tag contribs that are imported by other contribs; 3, tagging the rest of modules), they are the same code altogether ( Also, all the code is already tested in the PRs, nightlies, etc. |
BenchmarksBenchmark execution time: 2024-12-04 16:12:20 Comparing candidate commit 74620b4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
ddtrace/tracer: initialize runtimeMetricsV2 with statsd "direct" client (#3006) Co-authored-by: Felix Geisendörfer <[email protected]> Co-authored-by: Nayef Ghattas <[email protected]> fix(.github/workflows): add tags-ignore to avoid running CI on pushing tags for contribs and other nested modules (#3005) Co-authored-by: Hannah Kim <[email protected]> contrib/envoyproxy: envoy external processing support (#2895) This PR adds a new gRPC Interceptor (StreamServerInterceptor) to support the interception of ext_proc v3 calls to gRPC server. When the interceptor is applied, all messages of the external processing protocol are instrumented without returning an handle to the original server code Co-authored-by: Eliott Bouhana <[email protected]> Co-authored-by: Flavien Darche <[email protected]> add go mod to workflows/apps (#3036) go.mod: module go.opentelemetry.io/collector/pdata@latest found (v1.21.0), but does not contain package go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental (#3042) Signed-off-by: Eliott Bouhana <[email protected]> chore: update latest majors (#2993)
ddtrace/tracer: initialize runtimeMetricsV2 with statsd "direct" client (#3006) Co-authored-by: Felix Geisendörfer <[email protected]> Co-authored-by: Nayef Ghattas <[email protected]> fix(.github/workflows): add tags-ignore to avoid running CI on pushing tags for contribs and other nested modules (#3005) Co-authored-by: Hannah Kim <[email protected]> contrib/envoyproxy: envoy external processing support (#2895) This PR adds a new gRPC Interceptor (StreamServerInterceptor) to support the interception of ext_proc v3 calls to gRPC server. When the interceptor is applied, all messages of the external processing protocol are instrumented without returning an handle to the original server code Co-authored-by: Eliott Bouhana <[email protected]> Co-authored-by: Flavien Darche <[email protected]> add go mod to workflows/apps (#3036) go.mod: module go.opentelemetry.io/collector/pdata@latest found (v1.21.0), but does not contain package go.opentelemetry.io/collector/pdata/internal/data/protogen/profiles/v1experimental (#3042) Signed-off-by: Eliott Bouhana <[email protected]> chore: update latest majors (#2993)
4 participants
What does this PR do?
Adding
tags-ignoreto all GitHub Actions' workflows so they don't run when pushing tags.Motivation
dd-trace-go@v2has 50+ tags per release, so pushing them generate a lot of workload in CI.Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!