Skip to content

internal/civisibility: add support for the test.source.end tag#2911

Merged
tonyredondo merged 3 commits into
mainfrom
tony/civisibility-test-source-end-support
Oct 4, 2024
Merged

internal/civisibility: add support for the test.source.end tag#2911
tonyredondo merged 3 commits into
mainfrom
tony/civisibility-test-source-end-support

Conversation

@tonyredondo

Copy link
Copy Markdown
Member

What does this PR do?

This PR adds a logic to calcule the test.source.end tag with the end line number of a test function using the ast parser. It's a best effort approach, in case we cannot extract it (eg: no source code is available) then we silently bail out.

Motivation

This part of the CI Visibility specs.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo self-assigned this Oct 4, 2024
@tonyredondo
tonyredondo marked this pull request as ready for review October 4, 2024 11:08
@tonyredondo
tonyredondo requested a review from a team as a code owner October 4, 2024 11:08
@tonyredondo
tonyredondo merged commit 966abf2 into main Oct 4, 2024
@tonyredondo
tonyredondo deleted the tony/civisibility-test-source-end-support branch October 4, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants