internal/civisibility: fixes the test parent status when the auto-retry feature ended up with a failed test and then a successful test.#2910
Merged
tonyredondo merged 2 commits intoOct 4, 2024
Conversation
…y feature ended up with a failed test and after that there's a successful test.
tonyredondo
changed the title
vitor-de-araujo
approved these changes
Oct 4, 2024
ManuelPalenzuelaDD
approved these changes
Oct 4, 2024
ManuelPalenzuelaDD
left a comment
ManuelPalenzuelaDD
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left a comment about updating a string
tonyredondo
deleted the
tony/civisiblity-auto-test-retry-parent-failure-fix
branch
October 4, 2024 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the scenario when a test fail after retrying and then a test passes, before the PR we were always setting the test parent status according the current test status, so a previous failure status gets overwrote by a test passing status.
Motivation
This is fix on an actual bug in the implementation.
Reviewer's Checklist
Unsure? Have a question? Request a review!