Implement DD_TRACE_LOG_DIRECTORY#2901
Merged
Merged
Conversation
BenchmarksBenchmark execution time: 2024-10-07 21:21:53 Comparing candidate commit a9d646d in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics. scenario:BenchmarkInjectW3C-24
|
6 tasks
mtoffl01
marked this pull request as ready for review
October 2, 2024 15:33
darccio
approved these changes
Oct 3, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports specifying a log directory for tracer logs via
DD_TRACE_LOG_DIRECTORYenv var. If directory exists on the underlying os, tracer creates log fileddtrace.logat specified path and all tracer logs are routed to said file. Tracer maintains default behavior (log to stdout) if directory is invalid or does not exist.Motivation
Bring dd-trace-go up to speed on feature parity (other tracing libs support this). RFC
Reviewer's Checklist
Unsure? Have a question? Request a review!