internal/civisibility: change the default value for DD_CIVISIBILITY_ENABLED to false#2893
Merged
Merged
Conversation
…bled to be false at least for preview releases. So users require to opt-in using an environment variable.
BenchmarksBenchmark execution time: 2024-09-26 21:49:33 Comparing candidate commit c2bfe58 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
anmarchenko
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the default value for CI Visibility enabled to be false at least for preview releases. So users require to opt-in using the
DD_CIVISIBILITY_ENABLEDenvironment variable.Motivation
We don't want to enable CI Visibility by default when we are running tests instrumented by orchestrion while we are in preview mode. We will revisit this once we go to GA.
Reviewer's Checklist
Unsure? Have a question? Request a review!