internal/civisibility: automatic test retries#2892
Merged
Conversation
tonyredondo
force-pushed
the
tony/civisibility-initialization-requests
branch
from
September 26, 2024 21:00
c3142af to
50e8be3
Compare
BenchmarksBenchmark execution time: 2024-10-03 22:12:07 Comparing candidate commit 3e279cb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tonyredondo
force-pushed
the
tony/civisibility-initialization-requests
branch
from
October 1, 2024 15:30
39d8c89 to
f3ac8b9
Compare
tonyredondo
changed the title
tonyredondo
force-pushed
the
tony/civisibility-initialization-requests
branch
from
October 2, 2024 11:09
f176609 to
868acf4
Compare
tonyredondo
marked this pull request as ready for review
October 2, 2024 11:36
vitor-de-araujo
approved these changes
Oct 2, 2024
ManuelPalenzuelaDD
approved these changes
Oct 3, 2024
ManuelPalenzuelaDD
left a comment
ManuelPalenzuelaDD
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left some very minor nits
…ings and early flake detection data at CI Visibility initialization.
…es as a test func wrapper (for EFD and Flaky Retries) # Conflicts: # internal/civisibility/constants/env.go
…r all the test metadata handling.
…add some comments.
…. Improved code comments. Fix an issue with the suite and module event closing when running retries.
tonyredondo
force-pushed
the
tony/civisibility-initialization-requests
branch
from
October 3, 2024 21:28
de7d8da to
3e279cb
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the automatic test retries ci visibility feature as described in the RFC: https://docs.google.com/document/d/1Cy6n-CHu0QPV1_Jn9yLCa3aBvgm1JjviFDEq6oUzyuQ/edit#heading=h.rnd972k0hiye
The PR also works as a foundation to implement Early Flake Detection feature in a subsequence PR.
Motivation
This is a new feature we are implementing across all CI Visibility libraries.
Reviewer's Checklist
Unsure? Have a question? Request a review!