Skip to content

internal/civisibility/integrations/gotesting: improve the isCiVisibilityEnabled and enable reporting Code Coverage percentage.#2866

Merged
tonyredondo merged 1 commit into
mainfrom
tony/civisibility-fixes-and-codecoverage
Sep 13, 2024
Merged

internal/civisibility/integrations/gotesting: improve the isCiVisibilityEnabled and enable reporting Code Coverage percentage.#2866
tonyredondo merged 1 commit into
mainfrom
tony/civisibility-fixes-and-codecoverage

Conversation

@tonyredondo

Copy link
Copy Markdown
Member

What does this PR do?

This PR fixes and issue with the atomic.Int32 used in the isCiVisibilityEnabled func, also enables reporting of the code coverage data in a test session.

Motivation

Iterating with orchestrion and finding issues and possible improvements.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

…ityEnabled func code, and enable reporting Code Coverage percentage.
@tonyredondo tonyredondo self-assigned this Sep 13, 2024
@tonyredondo
tonyredondo requested a review from a team as a code owner September 13, 2024 14:46

@ManuelPalenzuelaDD ManuelPalenzuelaDD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyredondo
tonyredondo merged commit 63f207d into main Sep 13, 2024
@tonyredondo
tonyredondo deleted the tony/civisibility-fixes-and-codecoverage branch September 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants