Skip to content

[v2] ddtrace/tracer: tidy up Tracer interface#2633

Merged
darccio merged 1 commit into
v2-devfrom
dario.castane/tracer-iface-tidyup
May 8, 2024
Merged

[v2] ddtrace/tracer: tidy up Tracer interface#2633
darccio merged 1 commit into
v2-devfrom
dario.castane/tracer-iface-tidyup

Conversation

@darccio

@darccio darccio commented Mar 26, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This PR tidies up the Tracer interface for v2. It adds some functions to allow tracers implementing the interface to integrate with our implementation.

Motivation

v2 work was interrupted due to team changes. To reach release candidate quality we need to resolve pending TODOs regarding public API.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner March 26, 2024 15:35
@darccio
darccio requested review from knusbaum and removed request for a team March 26, 2024 15:36
@pr-commenter

pr-commenter Bot commented Mar 26, 2024

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2024-03-26 15:51:28

Comparing candidate commit 7c15f9f in PR branch dario.castane/tracer-iface-tidyup with baseline commit 42807ee in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@knusbaum knusbaum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions

github-actions Bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale Stuck for more than 1 month label May 1, 2024
@darccio
darccio merged commit f0eee6a into v2-dev May 8, 2024
@darccio
darccio deleted the dario.castane/tracer-iface-tidyup branch May 8, 2024 14:15
@darccio darccio removed the stale Stuck for more than 1 month label Jul 2, 2024
@darccio darccio added the v2.0 label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants