Skip to content

internal/telemetry: export Products field#2500

Merged
katiehockman merged 2 commits into
mainfrom
katie.hockman/otel-test-flake
Jan 11, 2024
Merged

internal/telemetry: export Products field#2500
katiehockman merged 2 commits into
mainfrom
katie.hockman/otel-test-flake

Conversation

@katiehockman

@katiehockman katiehockman commented Jan 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Export the Products field of the ProductsPayload struct, since this is required for the JSON marshaling to work properly.

Motivation

Fixes #2499

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter

pr-commenter Bot commented Jan 11, 2024

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2024-01-11 16:10:19

Comparing candidate commit a617265 in PR branch katie.hockman/otel-test-flake with baseline commit 8de8527 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@katiehockman
katiehockman force-pushed the katie.hockman/otel-test-flake branch from 9c2b375 to 772ab85 Compare January 11, 2024 16:44
@katiehockman katiehockman changed the title WIP: tracer: fix OTel test internal/telemetry: export Products field Jan 11, 2024
@katiehockman
katiehockman marked this pull request as ready for review January 11, 2024 16:46
@katiehockman
katiehockman requested review from a team as code owners January 11, 2024 16:46
@katiehockman
katiehockman merged commit 7d7770f into main Jan 11, 2024
@katiehockman
katiehockman deleted the katie.hockman/otel-test-flake branch January 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@RomainMuller RomainMuller RomainMuller approved these changes
@nsrip-dd nsrip-dd nsrip-dd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A single OTel test fails, but only on CI

4 participants

@katiehockman @darccio @RomainMuller @nsrip-dd