tracer: fix example and add SamplingRule function tests#2493
Merged
Conversation
katiehockman
marked this pull request as ready for review
January 9, 2024 19:31
BenchmarksBenchmark execution time: 2024-01-09 19:44:36 Comparing candidate commit 4d6d978 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
darccio
approved these changes
Jan 10, 2024
katiehockman
enabled auto-merge (squash)
January 10, 2024 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
tracer.SpanNameServiceRule(the order was flipped)SamplingRuleinstead, but it was never done, so the tests are identical and appear twice. This fixes that, and adds some missing tests.Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!