Skip to content

ddtracer/tracer: update TestStartupLog/errors & TestLogSamplingRules to new sampling rules implementation in v2#2492

Merged
knusbaum merged 2 commits into
v2-devfrom
dario.castane/fix-sampling-tests
Jan 9, 2024
Merged

ddtracer/tracer: update TestStartupLog/errors & TestLogSamplingRules to new sampling rules implementation in v2#2492
knusbaum merged 2 commits into
v2-devfrom
dario.castane/fix-sampling-tests

Conversation

@darccio

@darccio darccio commented Jan 9, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Updates TestStartupLog/errors to handle the way that sampling rules work in #2448, as in v2 it causes to return an error when creating the tracer. The error is logged as before, but we don't need to run the tracer to create it.

Motivation

Keeping v2 green.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio darccio added the v2.0 label Jan 9, 2024
@darccio
darccio requested a review from a team as a code owner January 9, 2024 16:58
@darccio darccio changed the title ddtracer/tracer: update TestStartupLog/errors to new sampling rules implementation in v2 ddtracer/tracer: update TestStartupLog/errors & TestLogSamplingRules to new sampling rules implementation in v2 Jan 9, 2024
@knusbaum
knusbaum merged commit 8910183 into v2-dev Jan 9, 2024
@knusbaum
knusbaum deleted the dario.castane/fix-sampling-tests branch January 9, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants