ddtrace/tracer: locking sampling decision after context propagation#2483
Merged
dianashevchenko merged 3 commits intoJan 8, 2024
Merged
Conversation
BenchmarksBenchmark execution time: 2024-01-08 14:02:16 Comparing candidate commit 5336d81 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
knusbaum
reviewed
Jan 5, 2024
darccio
requested changes
Jan 8, 2024
Comment on lines
+348
to
+354
| func (t *trace) isTraceLocked() bool { | ||
| t.mu.RLock() | ||
| defer t.mu.RUnlock() | ||
| return t.locked | ||
| } | ||
|
|
||
| func (t *trace) setTraceLocked(locked bool) { |
Member
There was a problem hiding this comment.
nit (optional, you can ignore this): I would suggest removing the "trace" part in the functions as it introduces repetition.
Suggested change
| func (t *trace) isTraceLocked() bool { | |
| t.mu.RLock() | |
| defer t.mu.RUnlock() | |
| return t.locked | |
| } | |
| func (t *trace) setTraceLocked(locked bool) { | |
| func (t *trace) isLocked() bool { | |
| t.mu.RLock() | |
| defer t.mu.RUnlock() | |
| return t.locked | |
| } | |
| func (t *trace) setLock(locked bool) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, the sampling decision of the span could be updated if new tags were set or a resource name updated. Now, this is onlyu possible up to a moment where a context is injected / propagated to preserve the connections between spans and avoid broken traces with different sampling priorities.
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!