ddtrace/tracer: removed target_span + trying to sample at the end#2464
Merged
dianashevchenko merged 8 commits intoDec 27, 2023
Merged
Conversation
BenchmarksBenchmark execution time: 2023-12-27 15:40:28 Comparing candidate commit b8e9744 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
dianashevchenko
commented
Dec 22, 2023
Comment on lines
+159
to
+161
| if c == nil { | ||
| return "" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This was found to cause panic in some tests, when span.String method is called
dianashevchenko
marked this pull request as ready for review
December 27, 2023 13:41
darccio
approved these changes
Dec 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!