ddtrace/tracer: only listen on localhost in TestTransportResponse#2463
Merged
Conversation
If we pass net.Listen an empty host, we'll listen on all available addresses. macOS will warn about the app accepting incoming network connections if we do this, creating an annoying popup each time we run the whole tracer test suite. Using localhost is sufficient for this test.
BenchmarksBenchmark execution time: 2023-12-21 14:46:59 Comparing candidate commit 7d19826 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
Member
|
Yeah, good catch! |
darccio
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Listen on localhost in
TestTransportResponseMotivation
If we pass net.Listen an empty host, we'll listen on all available
addresses. macOS will warn about the app accepting incoming network
connections if we do this, creating an annoying popup each time we run
the whole tracer test suite. Using localhost is sufficient for this
test.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!