Configure parametric test to get the golang tracer in same way as system-tests#2462
Merged
darccio merged 2 commits intoDec 21, 2023
Conversation
darccio
approved these changes
Dec 21, 2023
BenchmarksBenchmark execution time: 2023-12-21 12:03:42 Comparing candidate commit 3652318 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
…rameric_tests_set_golang_tracer
darccio
deleted the
robertomonteromiguel/robertomonteromiguel/parameric_tests_set_golang_tracer
branch
December 21, 2023 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Parametric only executes tests using latest tracer release. We add support to run snapshot version of the golang tracer (dev).
The idea behind this is to use the same approach to install dd-trace-go as is used by system-tests (maintainability reasons).
We are using the previously existing script to install the tracer: utils/build/docker/golang/install_ddtrace.sh.
This PR is a intermediate steps to avoid conflicts on the tracer pipelines during the "migration process".
I will create a new PR to clean the obsolete code after merge the system-tests PR: DataDog/system-tests#1948
(Sorry for the msg of the first commit...copy-paste...)
What does this PR do?
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!