ddtrace/tracer: add JSON logging workaround for tracer logs in WithLogger docs#2406
Merged
Merged
Conversation
BenchmarksBenchmark execution time: 2023-12-01 12:43:23 Comparing candidate commit 80fabcd in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics. |
ahmed-mez
approved these changes
Dec 1, 2023
darccio
deleted the
dario.castane/AIT-9101/json-logging-workaround-docs
branch
December 1, 2023 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a comment with link to the workaround in the WithLogger, as detailed in #2152 (comment)
Closes #2152
Motivation
Some customers and projects want to have all logs generated as JSON, including the tracer diagnostic and startup logs.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!