ddtrace/tracer: added DD_TRACE_SAMPLING_RULES_FILE env var#2404
Merged
dianashevchenko merged 4 commits intoNov 30, 2023
Merged
Conversation
dianashevchenko
changed the base branch from
main
to
shevchenko/tag-resource-sampling
November 30, 2023 15:14
darccio
requested changes
Nov 30, 2023
BenchmarksBenchmark execution time: 2023-11-30 16:08:16 Comparing candidate commit cdc92a7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support to extract trace sampling rules from the file, just like it is supported for span sampling rules .
Motivation
The sampling rule struct is gaining complexity through 3 additional fields, which makes adding sampling rules through a file easier and more comfortable
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!